Crime Reports sensor#6047
Conversation
|
@happyleavesaoc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
| self._state = None | ||
| self._previous_incidents = set() | ||
| self.update = Throttle(interval)(self._update) | ||
| self.update() |
There was a problem hiding this comment.
Use SCAN_INTERVAL = timedelta() on top of your script and remove this update here. You can call add_devices(..., True) for make a update bevor he add this to statemachine.
There was a problem hiding this comment.
Added SCAN_INTERVAL and removed interval config option.
|
Hello @happyleavesaoc, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
There was a problem hiding this comment.
'homeassistant.util.Throttle' imported but unused
b9b3a5d to
39e1941
Compare
39e1941 to
242bc3b
Compare
|
I don't think that we should use the zone component to do the input. It feels… weird I guess? I would expect a latitude, longitude and radius to be added to the config. If not passed in, default to the Home Assistant instance latitude/longitude. To make sure the user either supplies both latitude/longitude or none, use vol.Include (example) |
|
@happyleavesaoc any updates on this PR? |
|
If you plan to finish that, please reopen it. |
Description:
Add sensor for crimereports.com
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2062
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.