Skip to content

Crime Reports sensor#6047

Closed
happyleavesaoc wants to merge 3 commits into
home-assistant:devfrom
happyleavesaoc:crimereports
Closed

Crime Reports sensor#6047
happyleavesaoc wants to merge 3 commits into
home-assistant:devfrom
happyleavesaoc:crimereports

Conversation

@happyleavesaoc
Copy link
Copy Markdown
Contributor

@happyleavesaoc happyleavesaoc commented Feb 16, 2017

Description:

Add sensor for crimereports.com

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2062

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: crimereports
    zone: neighborhood

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link
Copy Markdown

@happyleavesaoc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

self._state = None
self._previous_incidents = set()
self.update = Throttle(interval)(self._update)
self.update()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SCAN_INTERVAL = timedelta() on top of your script and remove this update here. You can call add_devices(..., True) for make a update bevor he add this to statemachine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added SCAN_INTERVAL and removed interval config option.

@homeassistant
Copy link
Copy Markdown
Contributor

Hello @happyleavesaoc,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'homeassistant.util.Throttle' imported but unused

@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 19, 2017

I don't think that we should use the zone component to do the input. It feels… weird I guess?

I would expect a latitude, longitude and radius to be added to the config. If not passed in, default to the Home Assistant instance latitude/longitude.

To make sure the user either supplies both latitude/longitude or none, use vol.Include (example)

@andrey-git
Copy link
Copy Markdown
Contributor

@happyleavesaoc any updates on this PR?

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Mar 10, 2017

If you plan to finish that, please reopen it.

@pvizeli pvizeli closed this Mar 10, 2017
@happyleavesaoc happyleavesaoc mentioned this pull request Apr 6, 2017
6 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants